Allow users to disable version validation to downgrade clusters #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
reviewed
Jan 24, 2022
What about |
Sounds good to me. I changed it. |
|
I just retested on a new 8.0 snapshot and the |
This reverts commit 5543b12.
|
I removed the instructions requiring the additional suspend step which is no longer necessary. I am still trying to understand what has changed in Elasticsearch but I guess it makes ECK users' life easier. |
naemono
reviewed
Jan 24, 2022
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Jan 25, 2022
…tic#5272) Adds support for a new annotation called k8s.eck.elastic.co/disable-downgrade-validation as a troubleshooting tool to allow users that accidentally upgraded to the incorrect version to correct this mistake and go back to the previous version as long as Elasticsearch has not booted up and converted the data directory. This can be the case if the user upgraded to a version of Elasticsearch that does not exist or that refuses to boot because it is not on the upgrade path from the current version.
pebrc
added a commit
that referenced
this pull request
Jan 25, 2022
… (#5280) Adds support for a new annotation called k8s.eck.elastic.co/disable-downgrade-validation as a troubleshooting tool to allow users that accidentally upgraded to the incorrect version to correct this mistake and go back to the previous version as long as Elasticsearch has not booted up and converted the data directory. This can be the case if the user upgraded to a version of Elasticsearch that does not exist or that refuses to boot because it is not on the upgrade path from the current version.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
…tic#5272) Adds support for a new annotation called k8s.eck.elastic.co/disable-downgrade-validation as a troubleshooting tool to allow users that accidentally upgraded to the incorrect version to correct this mistake and go back to the previous version as long as Elasticsearch has not booted up and converted the data directory. This can be the case if the user upgraded to a version of Elasticsearch that does not exist or that refuses to boot because it is not on the upgrade path from the current version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5259
I tried to go with a different name for the annotation
permissive-version-validation, but I am not happy yet because we are not permissive on all version validations only on the one that prevents downgrades. So maybe we should go back to the proposal in the original issue.This is intended as a troubleshooting tool so I am going to only document it in the troubleshooting section.
I am currently aware of two use cases:
In both cases it should suffice to set the annotation and revert to the previous Elasticsearch version will get the user back into a working state.